Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfirmDialog: refs issue for react 19 #7523

Closed
XYIAN opened this issue Dec 23, 2024 · 6 comments · Fixed by #7539
Closed

ConfirmDialog: refs issue for react 19 #7523

XYIAN opened this issue Dec 23, 2024 · 6 comments · Fixed by #7539
Assignees
@melloware
Labels
React 18/19 Issue or pull request is *only* related to React 18/19
Milestone
10.9.0

Comments

@XYIAN
Copy link

XYIAN commented Dec 23, 2024

Describe the bug

Although this technically is working, the functional confirmDialog() callings refs will not work properly with react 19. When upgrading to react 19 you can see this issue when trying to toggle close more than once.

Reproducer

https://stackblitz.com/edit/confirm-dialog-console-warning

System Information

react: 19
prime react: latest

Steps to reproduce the behavior

add in a parent component and call confirmDialog in any child.

Expected behavior

expected no issues, no console errors and in react 19 expected smooth open and close.
@XYIAN XYIAN added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 23, 2024
@XYIAN
Copy link
Author

XYIAN commented Dec 23, 2024

ref-error

@sja-cslab
Copy link
Contributor

Current PrimeReact Version isn't build on top of V19.
PrimeReact currently gets a complete rework of PrimeTek till that you should keep using V18. The Problem here is, that PrimeReact is using a lot of refs. You could make a PR and try to get rid of all of it else i bet you've to wait for next PrimeReact version

@melloware melloware added React 18/19 Issue or pull request is *only* related to React 18/19 and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 23, 2024
@melloware
Copy link
Member

Duplicate of #7403 ???

@sja-cslab
Copy link
Contributor

@melloware Not sure - no next.js mentioned here

@melloware
Copy link
Member

Maybe this one:#7510

@sja-cslab
Copy link
Contributor

Yea same component

@melloware melloware mentioned this issue Jan 1, 2025
Merged
@melloware melloware self-assigned this Jan 1, 2025
@melloware melloware added this to the 10.8.6 milestone Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
React 18/19 Issue or pull request is *only* related to React 18/19
Projects
None yet
Milestone
10.9.0
Development

Successfully merging a pull request may close this issue.

Fix #7403: FocusTrap in React19 must not access element.ref melloware/primereact
3 participants
@melloware @XYIAN @sja-cslab