Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar: focus border and mask issue (material design theme) #7251

Open
djapal opened this issue Sep 25, 2024 · 5 comments
Open

Calendar: focus border and mask issue (material design theme) #7251

djapal opened this issue Sep 25, 2024 · 5 comments
Labels
Component: Theme Issue or pull request is related to Theme Type: Bug Issue contains a defect related to a specific component.

Comments

@djapal
Copy link

djapal commented Sep 25, 2024

Describe the bug

According to this codesandbox and using primereact 8.0.0, when focusing a calendar element, broder changes and also mask is shown. Also floating label moves up to indicate focus event.
Border changes color on focus but when "showIcon" is used, border doesnt change color (purple e.g. for indigo)
Using primereact 10.8.3 nothing happens

Reproducer

https://codesandbox.io/p/sandbox/musing-pateu-gmxvrk?file=%2Fpackage.json%3A12%2C27

System Information

Not sth specific for this

Steps to reproduce the behavior

Just focus on a calendar element

Expected behavior

No response

@djapal djapal added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 25, 2024
@sja-cslab
Copy link
Contributor

You should add a reproducer that shows the issue not one that shows an old working example - create a stackblitz with your issue please

@djapal
Copy link
Author

djapal commented Sep 25, 2024

You should add a reproducer that shows the issue not one that shows an old working example - create a stackblitz with your issue please

Hi. no need for reproducer. Just go to showcase, select material design theme and just focus on the calendar element.

@sja-cslab
Copy link
Contributor

Material
image

Lara
image

both seems to work - what exactly is the problem here? I dont see any issue

@djapal
Copy link
Author

djapal commented Sep 25, 2024

Example with primereact 8
image
Showcase with primereact 10.8.3
image

Ok seems that border is changed although is seems thinner when comparing with border of inputtext on focus event.
Still though the floating label doesnt go up, as when focusing other input elements. Also mask not shown when focusing. You can see the mask when trying to delete a selected date

@djapal
Copy link
Author

djapal commented Sep 25, 2024

seems that floating label doesnt go up at the position of the border, regardless of the theme, as i just checked.

@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 25, 2024
@melloware melloware changed the title Calendar focus border and mask issue (material design theme) Calendar: focus border and mask issue (material design theme) Sep 25, 2024
@melloware melloware added the Component: Theme Issue or pull request is related to Theme label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Theme Issue or pull request is related to Theme Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

3 participants