Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrimeReactProvider: Error next14 app router #5127

Closed
nicolasGallegos opened this issue Oct 20, 2023 · 8 comments · Fixed by #5674
Closed

PrimeReactProvider: Error next14 app router #5127

nicolasGallegos opened this issue Oct 20, 2023 · 8 comments · Fixed by #5674
Labels
Component: NextJS NextJS related issue Type: Bug Issue contains a defect related to a specific component. Type: SSR Issue related to server side rendering
Milestone

Comments

@nicolasGallegos
Copy link

Describe the bug

Captura de pantalla 2023-10-20 a la(s) 11 19 30 Captura de pantalla 2023-10-20 a la(s) 11 21 21 Captura de pantalla 2023-10-20 a la(s) 11 20 09 Captura de pantalla 2023-10-20 a la(s) 11 20 39

Reproducer

No response

PrimeReact version

10.0.3

React version

18.x

Language

TypeScript

Build / Runtime

Next.js

Browser(s)

chrome 118

Steps to reproduce the behavior

No response

Expected behavior

No response

@nicolasGallegos nicolasGallegos added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 20, 2023
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 20, 2023
@melloware melloware added the Status: Needs Reproducer Issue needs a runnable reproducer label Nov 1, 2023
Copy link

github-actions bot commented Nov 1, 2023

Please fork the CodeSandbox project or Stackblitz project and create a case demonstrating your bug report. This issue will be closed if no activities in 20 days.

@melloware
Copy link
Member

@nicolasGallegos I am not seeing this issue?

@nicolasGallegos
Copy link
Author

I tried it again but this time with Next 14 and I'm still getting the same result. I'll pass you the repository, maybe I'm doing something wrong. https://github.com/nicolasGallegos/next14-primereact

@melloware
Copy link
Member

melloware commented Nov 2, 2023

thanks I see its specifically Next Router related right?

I see others asking here: primefaces/sakai-react#47

@nicolasGallegos
Copy link
Author

Yes, it has to do with the app router but it only gives an error when using the PrimeReactProvider, from what I have tested.

@melloware
Copy link
Member

What happens if you set ripple:false in the provider same issue?

@melloware melloware changed the title PrimeReactProvider: Error next13 app router PrimeReactProvider: Error next14 app router Nov 9, 2023
@melloware melloware removed the Status: Needs Reproducer Issue needs a runnable reproducer label Nov 9, 2023
@melloware melloware added the Type: SSR Issue related to server side rendering label Nov 9, 2023
@melloware melloware added the Component: NextJS NextJS related issue label Nov 25, 2023
@hunghvu
Copy link

hunghvu commented Dec 15, 2023

A few minor versions back of the v10 series, I noticed PrimeReactProvider only works under Next use client component, or else, results in hydration issue. That does not seem to be the case anymore.

I suppose we are seeing the same situation here.

@melloware
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: NextJS NextJS related issue Type: Bug Issue contains a defect related to a specific component. Type: SSR Issue related to server side rendering
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants