Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Column: Pass Through does not apply header classes correctly #5125

Closed
iJulioDuarte opened this issue Oct 20, 2023 · 2 comments · Fixed by #5133
Closed

Column: Pass Through does not apply header classes correctly #5125

iJulioDuarte opened this issue Oct 20, 2023 · 2 comments · Fixed by #5133
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.0.6

Comments

@iJulioDuarte
Copy link

Describe the bug

When defining a classname through the Pass Through of the Column component, this class is not applied in the DOM

Reproducer

https://codesandbox.io/s/primereact-demo-forked-3rzd97?file=/src/App.js

PrimeReact version

10.0.5

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

Try defining a class for any div in the headerColumn by some property of the column pt and notice that it is not applied in the DOM

Expected behavior

It is expected that the classes applied to the pt will be correctly applied to the elements
@iJulioDuarte iJulioDuarte added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 20, 2023
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 20, 2023
@dmit4git dmit4git mentioned this issue Oct 21, 2023
Closed
melloware added a commit to melloware/primereact that referenced this issue Oct 21, 2023
@melloware
Fix primefaces#5125: Defensive handling of finding passthrough prop
eb50521
@melloware melloware mentioned this issue Oct 21, 2023
Merged
@melloware melloware self-assigned this Oct 21, 2023
@melloware melloware added this to the 10.0.6 milestone Oct 21, 2023
melloware added a commit to melloware/primereact that referenced this issue Oct 21, 2023
@melloware
Fix primefaces#5125: Defensive handling of finding passthrough prop
4d6e416
melloware added a commit that referenced this issue Oct 21, 2023
@melloware
Fix #5125: Defensive handling of finding passthrough prop (#5133)
5ba6169
@kabalan-datapostie
Copy link

+1 - thank you for fixing @melloware !

@melloware
Copy link
Member

No problem hopefully 10.0.6 will be out on Wednesday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.0.6
Development

Successfully merging a pull request may close this issue.

Fix #5125: Defensive handling of finding passthrough prop melloware/primereact
3 participants
@melloware @iJulioDuarte @kabalan-datapostie