Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TreeSelect filter input type #17629

Open
1 of 4 tasks
l-perine opened this issue Feb 10, 2025 · 0 comments
Open
1 of 4 tasks

TreeSelect filter input type #17629

l-perine opened this issue Feb 10, 2025 · 0 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@l-perine
Copy link

l-perine commented Feb 10, 2025

Describe the bug

example: https://primeng.org/treeselect#filter, presence of a blue delete cross that is basically unstylable

Cause: This is due to how the Treeselect and Tree component are tied together (see:

<input #filter pInputText type="search" autocomplete="off" class="p-tree-filter-input" [attr.placeholder]="filterPlaceholder" (keydown.enter)="$event.preventDefault()" (input)="_filter($event.target.value)" />
). The Tree component is the only place where a pInputText has the search type (that I could find).

I wish I could make a PR but I don't have the time and the solution picked (if this is considered an anomaly) would most likely result in more lost time down the road (as you can either decouple or add parameterability in the Tree component).

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/github-e1wrg7c2?file=src%2Fapp%2Fapp.component.ts

Environment

server: arch linux

Angular version

19.0.0

PrimeNG version

v19

Node version

No response

Browser(s)

any (seen in both edge and firefox, can't check safari but it's most likely the same)

Steps to reproduce the behavior

  1. click the component 2. enter anything in the filter

Expected behavior

the blue cross should be either hidden or at least stylable

@l-perine l-perine added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 10, 2025
@l-perine l-perine changed the title TreeSelect filter type TreeSelect filterinput type Feb 10, 2025
@l-perine l-perine changed the title TreeSelect filterinput type TreeSelect filter input type Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

1 participant