Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ButtonDirective changing severity does not update styles #16074

Open
danemesis opened this issue Jul 22, 2024 · 1 comment · May be fixed by #16167
Open

ButtonDirective changing severity does not update styles #16074

danemesis opened this issue Jul 22, 2024 · 1 comment · May be fixed by #16167
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@danemesis
Copy link

Describe the bug

Changing severity input for Directive does not change button styles.

primeng/src/app/components/button/button.ts

Line 112 in 98f9682

@Input() severity: 'success' | 'info' | 'warning' | 'danger' | 'help' | 'primary' | 'secondary' | 'contrast' | null | undefined;

Environment

126.0.6478.183 (Official Build) (arm64), macos

Angular version

18

PrimeNG version

17.18.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

v20.15.1

Browser(s)

Chrome

Steps to reproduce the behavior

change directive's severity and see that styles are not changing.

Expected behavior

Styles change once button's severity is updated

Reproduced

https://stackblitz.com/edit/stackblitz-starters-8skcaw?file=src%2Fmain.ts
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 22, 2024
@danemesis
Copy link
Author

I imagine if to update as label or other settable Input's it should work

primeng/src/app/components/button/button.ts

Line 72 in 98f9682

if (this.initialized) {

EnricoMessall added a commit to Arematics/primeng that referenced this issue Aug 4, 2024
@EnricoMessall
Fixed primefaces#16074 - ButtonDirective changing severity does not u…
d446dd8 
…pdate styles
@EnricoMessall EnricoMessall linked a pull request Aug 4, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed primefaces#16074 - ButtonDirective changing severity does not update styles Arematics/primeng
1 participant
@danemesis