Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table | Multiple Selection with dataKey shows wrong selected row count upon CTRL+A #15903

Closed
mehmetcetin01140 opened this issue Jun 25, 2024 · 1 comment · Fixed by #15904, #15917 or #15926 · May be fixed by Rodolphe33/gestion-personnel#12 or diaz-rigo/austins#17
Closed

Table | Multiple Selection with dataKey shows wrong selected row count upon CTRL+A #15903

mehmetcetin01140 opened this issue Jun 25, 2024 · 1 comment · Fixed by #15904, #15917 or #15926 · May be fixed by Rodolphe33/gestion-personnel#12 or diaz-rigo/austins#17
Assignees
@mehmetcetin01140
Labels
LTS-16-PORTABLE LTS-FIXED-16.9.12 PRO Support Issue was reported by PRO User Type: Bug Issue contains a bug related to a specific component. Something about the component is not working v18-port
Milestone
17.18.3

Comments

@mehmetcetin01140
Copy link
Contributor

Steps to reproduce:
Create a p-table with multiple selection enabled and use the dataKey property.
Populate the table with sample data.
Click on the Top rows in the table and press CTRL+A to select all rows.

Expected Result: All rows should be selected, and the selected row count should display the correct number of rows.

Actual Result: All rows are selected, but the selected row count is incorrect.

Sample Application: https://stackblitz.com/edit/z1cdw3-crjdxm?file=angular.json
@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working PRO Support Issue was reported by PRO User labels Jun 25, 2024
@mehmetcetin01140 mehmetcetin01140 added this to the 17.18.2 milestone Jun 25, 2024
@mehmetcetin01140 mehmetcetin01140 self-assigned this Jun 25, 2024
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 25, 2024
@mehmetcetin01140 mehmetcetin01140 mentioned this issue Jun 25, 2024
Merged
@mehmetcetin01140 mehmetcetin01140 removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 25, 2024
cetincakiroglu added a commit that referenced this issue Jun 27, 2024
@cetincakiroglu
Merge pull request #15904 from primefaces/issue-15903
6bdfff6 
Fixed #15903 - Table | Multiple Selection with dataKey shows wrong se…
@quentin-ineat-ca
Copy link

quentin-ineat-ca commented Jun 27, 2024 •
edited
Loading

@cetincakiroglu Unfortunately still not functional. Same stackblitz than above but updated primeng 17.18.2. https://stackblitz.com/edit/z1cdw3-snozxu
Cmd + a is now working but selection with datakey is now broken.

  1. CMD + A : ok
  2. Then CMD + Click on a line : The total is broken and duplicate all selected lines.

Please add unit tests for table because it's such a critical component 🙏
A bit disappointed that this ticket mentions 'datakey' and 'ctrl + a' but 'datakey' alone was not even tested after the fix.

@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 28, 2024
@mehmetcetin01140 mehmetcetin01140 mentioned this issue Jun 28, 2024
Merged
@cetincakiroglu cetincakiroglu removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 28, 2024
cetincakiroglu added a commit that referenced this issue Jun 28, 2024
@cetincakiroglu
Revert "Fixed #15903 - Table | Multiple Selection with dataKey shows …
0b87b1f 
…wrong selected row count upon CTRL+A"
cetincakiroglu added a commit that referenced this issue Jun 28, 2024
@cetincakiroglu
Merge pull request #15920 from primefaces/revert-15917-issue-15903
9fb155d 
Revert "Fixed #15903 - Table | Multiple Selection with dataKey shows wrong selected row count upon CTRL+A"
cetincakiroglu added a commit that referenced this issue Jun 28, 2024
@cetincakiroglu
Revert "Fixed #15903 - Table | Multiple Selection with dataKey shows …
82bc660 
…wrong se…"
cetincakiroglu added a commit that referenced this issue Jun 28, 2024
@cetincakiroglu
Merge pull request #15921 from primefaces/revert-15904-issue-15903
ceedbb9 
Revert "Fixed #15903 - Table | Multiple Selection with dataKey shows wrong se…"
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 1, 2024
@mehmetcetin01140 mehmetcetin01140 mentioned this issue Jul 1, 2024
Merged
@mehmetcetin01140 mehmetcetin01140 modified the milestones: 17.18.2, 17.18.3 Jul 1, 2024
cetincakiroglu added a commit that referenced this issue Jul 4, 2024
@cetincakiroglu
Merge pull request #15926 from primefaces/issue-15903
2140f19 
Fixed #15903 - Table | Multiple Selection with dataKey shows wrong se…
@mehmetcetin01140 mehmetcetin01140 added LTS-16-PORTABLE LTS-FIXED-16.9.12 and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jul 4, 2024
@Rodolphe33 Rodolphe33 mentioned this issue Jul 19, 2024
Open
@diaz-rigo diaz-rigo mentioned this issue Jul 21, 2024
Open
@Rodolphe33 Rodolphe33 mentioned this issue Jul 26, 2024
Open
@Rodolphe33 Rodolphe33 mentioned this issue Aug 2, 2024
Open
This was referenced Aug 9, 2024
Open
Open
@Rodolphe33 Rodolphe33 mentioned this issue Aug 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehmetcetin01140 mehmetcetin01140

Labels
LTS-16-PORTABLE LTS-FIXED-16.9.12 PRO Support Issue was reported by PRO User Type: Bug Issue contains a bug related to a specific component. Something about the component is not working v18-port
Projects
None yet
Milestone
17.18.3
Development

Successfully merging a pull request may close this issue.

Fixed #15903 - Table | Multiple Selection with dataKey shows wrong se… primefaces/primeng
Fixed #15903 - Table | Multiple Selection with dataKey shows wrong selected row count upon CTRL+A primefaces/primeng
Fixed #15903 - Table | Multiple Selection with dataKey shows wrong se… primefaces/primeng
[Snyk] Upgrade primeng from 17.14.1 to 17.18.2 Rodolphe33/gestion-personnel
[Snyk] Upgrade primeng from 17.12.0 to 17.18.2 diaz-rigo/austins
[Snyk] Upgrade primeng from 17.14.1 to 17.18.3 Rodolphe33/gestion-personnel
[Snyk] Upgrade primeng from 17.14.1 to 17.18.4 Rodolphe33/gestion-personnel
[Snyk] Upgrade primeng from 17.14.1 to 17.18.5 Rodolphe33/gestion-personnel
[Snyk] Upgrade primeng from 17.14.1 to 17.18.6 Rodolphe33/gestion-personnel
[Snyk] Upgrade primeng from 17.14.1 to 17.18.7 Rodolphe33/gestion-personnel
3 participants
@cetincakiroglu @mehmetcetin01140 @quentin-ineat-ca