Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute_welded_normals in bunny.ctm #31

Closed
sonoro1234 opened this issue Oct 15, 2019 · 1 comment
Closed

compute_welded_normals in bunny.ctm #31

sonoro1234 opened this issue Oct 15, 2019 · 1 comment

Comments

@sonoro1234
Copy link
Contributor

sonoro1234 commented Oct 15, 2019

Related to #30

When loading this ctm mesh:

bunny.zip

compute_welded_normals dont crash (as in #30) but there are normals not correctly calculated.
It can be avoided by recompiling par_shapes with
https://github.com/prideout/par/blob/master/par_shapes.h#L305
replaced by par_shapes_mesh* welded = par_shapes_weld(m, 0.001, weldmap);

So changing epsilon to a smaller size will not weld different position points.
It also makes #30 to happen only for higher values of slices and stacks.

I think it would be useful to provide access to the epsilon value, it could be done making it an argument to par_shapes__compute_welded_normals and to par_shapes_create_parametric

What do you think?
Shall I do a PR for that?

@prideout
Copy link
Owner

Yes let's make epsilon configurable. To keep the API simple I think I would prefer a "global config" rather than adding new arguments to those functions. I will make the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants