Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using surround to change into typographic quotes work. The other way around doesn't #11

Open
rafaeln opened this issue Oct 19, 2016 · 11 comments
Labels

Comments

@rafaeln
Copy link

rafaeln commented Oct 19, 2016

When you have 'something' and you do cs'q on it, you do get “something”, but when you have “something” and you do csq' on it, you don't get any change.

@reedes
Copy link
Collaborator

reedes commented Nov 8, 2016

I'll see if I can reproduce this. Thanks.

@dbaynard
Copy link

dbaynard commented Dec 3, 2016

I'm on vim 8.0 and getting the same error

@Porges
Copy link

Porges commented Jan 9, 2017

Also: dsq/dsQ don't work.

@reedes
Copy link
Collaborator

reedes commented Jan 12, 2017

I finally installed Tim Pope's surround plugin after not using it for a few years.

Changing from straight to curly works, but the reverse does not. So I'm seeing the same thing you are.

My apologies, as it's been so long since I last dealt with this that I can't even recall if it did work both ways. However, if somebody wants to dig into this and get it working, I'd be happy to accept a pull request.

@Porges
Copy link

Porges commented Jan 13, 2017

After looking at the code it seems like surround.vim doesn't support this... I could have sworn it used to work! 🙂

Here's the issue on surround: tpope/vim-surround#210

@alerque
Copy link
Member

alerque commented Jun 1, 2020

This works for me now. I have no idea when or how the fix took place — maybe it's my fork of tpope's pluign?

Is anybody else still experiencing this?

@alerque alerque added the bug label Jun 1, 2020
@telemachus
Copy link
Collaborator

telemachus commented Feb 9, 2022

I'm inclined to close this. (Nearly two years without any responses.)

/ping @alerque

@alerque
Copy link
Member

alerque commented Feb 11, 2022

Yup. Still no repro here. If anybody is still having this issue please comment and we'll review your situation.

@alerque alerque closed this as completed Feb 11, 2022
@andrew-vant
Copy link

andrew-vant commented Feb 18, 2022

Hate to re-open this right after it was closed, but I'm having this issue. vim-surround commit baf89ad, vim-textobj-quote commit 7ce5b32, vim-textobj-user commit 41a675d.

@alerque
Copy link
Member

alerque commented Feb 18, 2022

@andrew-vant Fair enough. I'm guessing you are a victim of tpope/vim-surround#210, you can try my fork here. I'm guessing that's why I can't repro this.

@telemachus
Copy link
Collaborator

telemachus commented Feb 18, 2022

Should we add a test for this? Or is it something that we can't fix,
so testing for it effectively doesn't matter?

I haven't used surround in years (I use vim-sandwich instead,
which—as a side note—I recommend very highly), but I will try to
look into this when I can, though it sounds like we can't
fix it from our end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants