Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

“Subfont”.tff fallback doesn't work in (infrequently) description and (mostly in) comments #117

Open
idontveapc opened this issue Apr 6, 2024 · 2 comments

Comments

@idontveapc
Copy link

App uses two fonts for regular typeface. I believe “Subfont”.ttf is used for fallback for missing characters in regular font.(or other) To test if you can get missing character/s you could check the fallback.

In my test, i used a font file with zero characters which when you use instead the regular font; (latin) characters fallback to system not subfont.

@prateekmedia
Copy link
Owner

We use NotoSans as primary font, can you clarify your statement more by a screenshot?

@idontveapc
Copy link
Author

Yup, in the new version (beta) subfont isnt used. So, illustrations below are from the previous version (nightly).

Now i just want to prove it by the “,” ("comma"). The SysSans fallback (font) has comma that looks different in Subfont. The comma fallback is mostly present in search bar and (channel) home:
ResizedImage_2024-04-06_20-02-40_9637

But not in comments and descriptions (mostly but not always) –here commma in search bar is different than in video title. In the second image description;
ResizedImage_2024-04-06_20-03-38_2577
also has comma from SysSans:
ResizedImage_2024-04-06_20-03-18_8075

The SysSans fallback isn't too bad, but it's enough bad. Because it covers mostly CJK characters; charactors like: ’(single quote), ”(double quote) are badly spaced. As they are as “fullwidth” in the font.

Though all the latin characters don't fallback to Subfont at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants