Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only fetches the first 10 files/dirs #13

Open
TigreModerata opened this issue Feb 16, 2023 · 2 comments
Open

Only fetches the first 10 files/dirs #13

TigreModerata opened this issue Feb 16, 2023 · 2 comments

Comments

@TigreModerata
Copy link

Maybe I'm doing something wrong, but with the main version I can only get 10 results for ls, dir or get/pull. I cloned the repo and changed the pagesize in fetch to 100 (just to get something done quickly) and it now fetches all files, more than 100... Nobody has mentioned this before, so I'm guessing I did something wrong. If not, if this is the intended behaviour, max 10 results, might it be worth including the option to get them all?

@prahladyeri
Copy link
Owner

Sorry for the delay, I was occupied with other things. The problem here seems to be pageSize parameter which is hardcoded to 10 here:

q=query,orderBy=sort,pageSize=10,fields="nextPageToken, files(id, name)").execute()

I've made a note of removing this hard-coding and making it configurable in the upcoming version. Stay tuned!

@TigreModerata
Copy link
Author

TigreModerata commented Feb 18, 2023

cool, thanks!
(I got what I needed out of it anyway, by setting the pagesize, and it is really helpful and easy to use!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants