Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This fails to build on modern versions of Node. Gulp and Babel are 1 major version behind. #78

Open
DevOpsJon opened this issue Mar 11, 2025 · 1 comment
Open

This fails to build on modern versions of Node. Gulp and Babel are 1 major version behind. #78

DevOpsJon opened this issue Mar 11, 2025 · 1 comment

Comments

@DevOpsJon
Copy link

I tried to build this on Node 23.9.0 and ran into several problems:

Babel 6 is old (Breaking changes)
Gulp 3 is old (Breaking changes)
Sass depracation warnings happen on every build.
Lots of outdated deps.

I was able to update these packages and fix the breaking changes locally. PR inbound.
DevOpsJon pushed a commit to DevOpsJon/flip that referenced this issue Mar 11, 2025
This PR addresses the issues mentioned in pqina#78 by updating the bu…
d09b1a1 
…ild toolchain to work with modern Node.js versions.

- **Migrated from Babel 6 to Babel 7**
  - Replaced babel-preset-es2015 with @babel/preset-env
  - Updated plugins to use @babel/plugin-transform-object-rest-spread
  - Added proper Babel configuration with babel.config.js

- **Upgraded from Gulp 3 to Gulp 4**
  - Updated task system to use series/parallel pattern
  - Modified gulpfile.babel.js for compatibility with current APIs
  - Improved async handling with promises

- **Fixed Sass deprecation warnings**
  - Updated gulp-dart-sass implementation to use current API

- **Updated dependencies**
  - Replaced outdated and deprecated packages
  - Updated package versions to latest compatible releases
  - Added missing dependencies

The build system now successfully works on Node.js v23.9.0 and produces the same output as before.

All functionality remains the same - this PR only addresses build system compatibility issues.
@DevOpsJon DevOpsJon mentioned this issue Mar 11, 2025
Open
DevOpsJon added a commit to DevOpsJon/flip that referenced this issue Mar 11, 2025
@DevOpsJon
Merge pull request #1 from DevOpsJon/fix/modernize-build-toolchain
5357869 
This PR addresses the issues mentioned in pqina#78 by updating the build t…
@rikschennink
Copy link
Collaborator

Thanks, truly appreciate it, currently swamped but I have some time I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rikschennink @DevOpsJon