Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminal echo #10

Open
GralfR opened this issue Mar 9, 2021 · 1 comment
Open

terminal echo #10

GralfR opened this issue Mar 9, 2021 · 1 comment

Comments

@GralfR
Copy link

GralfR commented Mar 9, 2021

When I first used SerialCommands with the given example and putty I wondered why this didn't work.
The first problem was the line-ending, which I then matched on putty and SerialCommands.
The second thing was: there was no echo of the input on the client.
Okay, one could force putty to do an echo itself.
My way was to add an echo to SerialCommands.
Inside SerialCommands.cpp i've added a
Serial.write(ch); //ECHO
after the
int ch = serial_->read();
inside the ReadSerial() function.

In my case this is working, but I think this could be done better, at least concerning a multi-serial-support.
Maybe You'd like to add an echo-option to Your code and also make that an option to the initialisation (maybe a TRUE or FALSE behind the delimiter argument?).

Thanks

@gr-butler
Copy link

+1
Was going to submit a PR with exactly that but don't have permission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants