-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is there is reson to use full pouchdb in dependency ? #241
Comments
That does seem alluring, but I'm not sure if it is technically correct. Ember should also be able to work in node, for example with fastboot. I'm not sure if ember-pouch works with fastboot, but using pouchdb-browser would surely prevent this. We could make the user choose through peer or optional dependencies. But that would make an out of the box installation harder. |
How ember-data work with fastboot ? Isn't it for client side only ? Oh, I see there is addon for it https://github.com/cardstack/ember-data-fastboot And we get not popular method for caching ember-data models VERSUS problems with compiling |
Yes, it might be better to let people who really want fastboot to have to do more work. But I'm not sure if using pouchdb-browser would make that impossible, or just a little bit harder. We would have to look into whether pouchdb-browser comes with the required distribution files we use to load pouchdb-find before we can really switch tough. |
https://pouchdb.com/custom.html Seems pouchdb-find does not included in pouchdb-browser. But I think not big problem |
It does require us to either use pouchdb-browser as a direct dependency or go the peerDependency route. Peer dependencies are technically more correct, but harder to get right for normal users. Maybe we can use |
Just one more line in readme/changelog |
Why not use only
pouchdb-browser
? In that case there will be no need to compile leveldown which is not needed at all for ember.The text was updated successfully, but these errors were encountered: