Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace backslash style path to forward slash #441

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: replace backslash style path to forward slash #441

wants to merge 3 commits into from
+28 −0

Conversation

Gehbt
Copy link

@Gehbt Gehbt commented Jul 9, 2024

fix 440, by replace backslash.

posva
posva requested changes Jul 9, 2024
View reviewed changes
Copy link
Owner

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix shouldn’t be this. Normally parts were this can create problems are handled through pathe but I can’t currently test on windows
It would be better to check other usages of pathe to understand where the fix should be

@Gehbt Gehbt closed this Jul 10, 2024
@Gehbt Gehbt reopened this Jul 10, 2024
@posva posva marked this pull request as draft July 10, 2024 07:23
@Gehbt Gehbt marked this pull request as ready for review July 10, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

generatePageImport error handling path variable of win32 style
2 participants
@Gehbt @posva