Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postlight Reader | URLs broken #738

Open
TheOnlyWayUp opened this issue Apr 2, 2023 · 1 comment
Open

Postlight Reader | URLs broken #738

TheOnlyWayUp opened this issue Apr 2, 2023 · 1 comment

Comments

@TheOnlyWayUp
Copy link

Expected Behavior

After I use the Postlight Reader Extension, I expect all links in the cleaned article to be functional.

Current Behavior

In the cleaned document (presented by the Postlight Reader extension), Links go from
/path (relative url)
to
chrome-extension://oknpjjbmpnndlpmnhmekjpocelpnlfdi/path.

Steps to Reproduce

  • Open a web page containing relative URL
<a href="/test">
<a href="https://google.com/test">
  • Parse with Postlight Reader Extension
  • First link stops working, as the website domain changes to the chrome extension domain, all relative urls break

Possible Solution

While the article is being cleaned, retrieve the domain name and suffix all relative urls (href="/path") with the domain (href="domain.com/path").


Cool stuff, thank you :)

@Rilomilo
Copy link

Yes, I have the same issue, relative url breaks in many other contexts too. Absolute url is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants