Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a keybinding for opening the Variables view #6050

Closed
jmcphers opened this issue Jan 18, 2025 · 5 comments
Closed

Provide a keybinding for opening the Variables view #6050

jmcphers opened this issue Jan 18, 2025 · 5 comments
Labels
area: variables Issues related to Variables category.

Comments

@jmcphers
Copy link
Collaborator

The Variables view is one of the most useful and frequently used panes in Positron, but there's no way to activate it with a keyboard shortcut (outside of using the Command Palette). We do have a command which opens it:

Image

However, it doesn't have a keybinding. We should add one to help make this pane keyboard-navigable.

@jmcphers jmcphers added the area: variables Issues related to Variables category. label Jan 18, 2025
jmcphers added a commit that referenced this issue Jan 21, 2025
Adds a custom focus command to focus the Variables view; addresses
#6050.

### Release Notes

#### New Features

- Add keybinding <kbd>Cmd</kbd> <kbd>K</kbd>, <kbd>V</kbd> for keyboard
access to open/focus Variables view.
#6050

#### Bug Fixes

- N/A


### QA Notes

N/A
@midleman
Copy link
Contributor

Verified Fixed

Positron Dev Version: 2025.02.0 build 0
Code - OSS Version: 1.96.0
Commit: Unknown
Date: Unknown
Electron: 32.2.6
Chromium: 128.0.6613.186
Node.js: 20.18.1
V8: 12.8.374.38-electron.0
OS: Darwin arm64 24.2.0

Test scenario(s)

I updated existing tests to use these new key bindings to verify they work as expected:
#6119

Tests passed on all platforms.

@anbrav0
Copy link

anbrav0 commented Jan 30, 2025

Hello Positron team,

Thank you for including some keybindings for opening variables pane. Currently in the positron version

Positron Version: 2025.02.0 (Universal) build 79
Code - OSS Version: 1.96.0
Commit: a268bc86f313a0e454069790b1cbaadebc74262b
Date: 2025-01-21T02:44:54.581Z
Electron: 32.2.6
Chromium: 128.0.6613.186
Node.js: 20.18.1
V8: 12.8.374.38-electron.0
OS: Darwin arm64 24.0.0

and R version:
4.4.1

i see that the cmd + K F does indeed focus on the console, however, cmd + K V currently does not focus on the variables pane:

Image Image

Please let me know if there is something I might be doing wrong, and I apologize if there is already an issue/PR in the works for this

@juliasilge
Copy link
Contributor

Ah, the issue is that although #6060 was merged into main, a build incorporating that particular code hasn't yet made it to https://github.com/posit-dev/positron/releases. Let me see if we can get moving on that!

@juliasilge
Copy link
Contributor

@anbrav0 The new release is available now: https://github.com/posit-dev/positron/releases/tag/2025.02.0-137

@anbrav0
Copy link

anbrav0 commented Jan 30, 2025

Amazing! thank you! @juliasilge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: variables Issues related to Variables category.
Projects
None yet
Development

No branches or pull requests

4 participants