Editor action toolbar: several buttons do not work for .ipynb files
#5737
Assignees
Labels
area: top bar
Issues related to Top Bar category.
area: ui
Issues related to UI category.
bug
Something isn't working
Milestone
Comments
juliasilge
added
area: top bar
softwarenerd
added a commit
that referenced
this issue
Dec 19, 2024
…MouseDown` because VSCode Notebook Editor eats `onClick` events. (#5834) ### Description This PR addresses #5737 by switching the mouse trigger of `ActionBarButton`s from `MouseTrigger.Click` to `MouseTrigger.MouseDown`. This was necessitated because the VSCode Notebook Editor eats `onClick` events. ### QA Notes None at the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
System details:
Positron and OS details:
Positron Version: 2025.01.0 (Universal) build 60
Code - OSS Version: 1.93.0
Commit: 25b2d2e
Date: 2024-12-11T02:49:08.203Z
Electron: 30.4.0
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: 12.4.254.20-electron.0
OS: Darwin arm64 24.1.0
Describe the issue:
Several of the buttons we have moved from their regular positions to the editor action bar do not work, i.e. do not appear to be wired up to their respective commands correctly. Split right/down, move into new window, the
..., and the button contributed from another extension (the Posit Publisher extension) all do not work:I will point out that this is a custom editor and not a regular source editor.
Steps to reproduce the issue:
editor.actionBar.enabledExpected or desired behavior:
The buttons should behave the same as in their original location.
Were there any error messages in the UI, Output panel, or Developer Tools console?
None that I believe to be related.
The text was updated successfully, but these errors were encountered: