Positrons pops up "code-oss-dev Safe Storage" dialog when launched from within VSCode

[wesm]

This comes up frequently when launching Positron from within VSCode

[juliasilge]

This is the same as #1688

I think we have confirmed this only occurs for dev builds (does not impact users) and haven't been able to really consistently reproduce this.

@wesm do you have a pretty reliable set of actions that causes you to see this?

[wesm]

Yeah, if I close Positron, and then relaunch it from VSCode, I get it every time

[wesm]

Screen.Recording.2024-02-15.at.6.31.14.PM.mov

[wesm]

This pop up is originating from this file:

https://github.com/microsoft/vscode/blob/main/src/vs/platform/encryption/electron-main/encryptionMainService.ts

the exact line that causes the pop-up to show up is

https://github.com/microsoft/vscode/blob/main/src/vs/platform/encryption/electron-main/encryptionMainService.ts#L64

	isEncryptionAvailable(): Promise<boolean> {
		return Promise.resolve(safeStorage.isEncryptionAvailable());
	}

See https://www.electronjs.org/docs/latest/api/safe-storage

On my computer, I have a bunch of Electron apps that seem to use this API:

If this quirk seems to only apply to running Positron in development mode, maybe we can just fix the "code-oss-dev" piece (somehow?) to say "Positron" instead and recommend that people authorize the keychain access?

See also microsoft/vscode-discussions#748

[sharon-wang]

Release build instance of this issue: #5485

[jonvanausdeln]

Moving back into triage as we have at least 2 instances of this this in a release build.

[juliasilge]

This may possibly be related to recent work from the Connections pane that uses the secret storage.

[dfalbel]

I investigated this a little and it doesn't seem to be related to the secret storage usage in the connections pane (implemented in #5456) as even after removing all the refrences to the Secret storage in that files we still get the modals.

[juliasilge]

Thanks, @dfalbel! I'll move this back to triage for us to decide how to proceed.

Reported again in #5769