Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance -> Calculation: Don't mix up "no quote" and "no capital gains" #4195

Open
pfalcon opened this issue Aug 16, 2024 · 0 comments
Open
Labels

Comments

@pfalcon
Copy link
Contributor

pfalcon commented Aug 16, 2024

There can be cases, when Performance -> Calculation -> Calculation tab doesn't include a security in either "Capital Gains" or "Realized Capital Gains". This can be when e.g. when there's no quotes configured for security. Then current price == buy price, CG is 0, and the current filters in the code filter it out. Suggestion: avoid this and maintain invariant that a security appears in either "Capital Gains" or "Realized Capital Gains", or both. The reason is obvious: if PP randomly (to a user) drops securities from reporting, then how this reporting can be trusted?

Of course, such a behavior (or filtering out zero gains) can be a feature. For example, if one has thousands of assets, majority of which never appreciate, then not seeing them in a report may be beneficial. But such a rare, improbable case should be handled differently, e.g. by adding an explicit "Filter out zero gains" checkbox to settings for the tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant