Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout issue when using with Bun #817

Closed
lnlife opened this issue Feb 23, 2024 · 17 comments
Closed

Timeout issue when using with Bun #817

lnlife opened this issue Feb 23, 2024 · 17 comments

Comments

@lnlife
Copy link

lnlife commented Feb 23, 2024

I created a simple http server with http.createServer, and query database when requests come:
let rows = await sql.unsafe(query, args, { prepare: true })

After starting the server it works fine at beginning. But if do not send request after a while (maybe 1+ hour), then send request again, got query timeout:

22 |       errno: x,
23 |       address: options.path || host
24 |     }, options.path ? {} : { port: port }
25 |   )
26 |   Error.captureStackTrace(error, connection)
             ^
error: write CONNECT_TIMEOUT localhost:5432
 code: "CONNECT_TIMEOUT"

      at connection (/home/test/node_modules/postgres/src/errors.js:26:9)
      at connectTimedOut (/home/test/node_modules/postgres/src/connection.js:433:14)
      at done (/home/test/node_modules/postgres/src/connection.js:1035:12)

This issue only occurs on Bun, not on Node.(I've tested both)

@Nickhoyer
Copy link

I have the same issue. Seems to be fixed in November in #738 but there hasn't been any releases to npm.

@porsager is there any reason there hasn't been any releases to npm?

@amjed-ali-k
Copy link

@porsager Kindly release new version to npm. or a beta version.

@porsager
Copy link
Owner

You can install from github by using porsager/postgres#commithash

@porsager
Copy link
Owner

I have the same issue. Seems to be fixed in November in #738 but there hasn't been any releases to npm.

@porsager is there any reason there hasn't been any releases to npm?

No other reason than limited time on my end 😔

@porsager
Copy link
Owner

v3.4.4 released

@evelant
Copy link

evelant commented Apr 1, 2024

@porsager a new bug may have been introduced, now when calling postgres.end({timeout: 30}) it never completes until the timeout on my Bun app

@porsager
Copy link
Owner

porsager commented Apr 1, 2024

please test with node and let me know if there's an issue. If there is only an issue with bun you need to file it in the bun repo.

@evelant
Copy link

evelant commented Apr 1, 2024

@porsager I'll see if I can reproduce with node, but at least on Bun this is definitely a regression between 3.4.3 and 3.4.4. I rolled back to 3.4.3 and the connection terminates instantly instead of waiting for the timeout.

@porsager
Copy link
Owner

porsager commented Apr 1, 2024

right, the "workaround" solving the previous bun error probably shouldn't have been made, and instead solved in bun instead 😅

So from now on I'm not taking bug reports from bun anymore 😜 Bun has stated "many" times, that things working in node should work in bun, and bug reports should go to the bun repo then.

@amjed-ali-k
Copy link

amjed-ali-k commented Apr 1, 2024

@porsager
seems that "workaround" might be the issue. getting this so frequently now.

Bun 1.1.0 | PostgresJs 3.4.4 | drizzle-orm 0.30.6

image

@porsager
Copy link
Owner

porsager commented Apr 1, 2024

You should go thumb up that issue on bun ;) oven-sh/bun#7325

@Jarred-Sumner
Copy link

The fix for this will land in Bun v1.1.7, which we aim to release in a few hours

@wiesys
Copy link

wiesys commented May 15, 2024

Hmm... the issue with not properly closing the connection for me is present even in Bun v1.1.8. Does it work for you @evelant? 🤔

@evelant
Copy link

evelant commented May 15, 2024

I haven't tried it yet, sorry

@wiesys
Copy link

wiesys commented May 15, 2024

No worries, in case you have time, you could check so I can be sure that I'm not the only one 🙂

@dahlia
Copy link

dahlia commented May 17, 2024

@wiesys I'm using Postgres.js 3.4.4 on Bun 1.1.8 and the issue is still present.

@amjed-ali-k
Copy link

The fix for this will land in Bun v1.1.7, which we aim to release in a few hours

@Jarred-Sumner Its still there. oven-sh/bun#7325 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants