Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text Input does not have Spell Check and broken Text blocking #457

Closed
1 task
Linkachus17 opened this issue Oct 29, 2024 · 5 comments · Fixed by #459
Closed
1 task

Text Input does not have Spell Check and broken Text blocking #457

Linkachus17 opened this issue Oct 29, 2024 · 5 comments · Fixed by #459
Labels
bug Something isn't working

Comments

@Linkachus17
Copy link

💡 Summary

The input field does not support some useful features like: Text blocking, Spell Check…will this be added later?
Currently for Text blocking, it’s very buggy at best

🥰 Expected Behavior

Input field has a Spelling Check as well as ability to block a text

🤬 Actual Behavior

No Spell Check, Buggy Text blocking

📝 Steps to Reproduce

  1. Assuming Spell Check is ON, Write a post with typos

💻 Environment

* Model and OS of the device(s): iPhone XS iOS 18.1
* Aria: 0.15.1
* Server URL: misskey.de
* Misskey: 2024.10.1

Do you want to address this bug yourself?

  • Yes, I will patch the bug myself and send a pull request
@Linkachus17 Linkachus17 added the bug Something isn't working label Oct 29, 2024
@Linkachus17 Linkachus17 changed the title Input field fix Text Input does not have Spell Check and broken Text blocking Oct 29, 2024
@poppingmoon
Copy link
Owner

It would be good to add a spell check, but I think it should be optional because things like custom emojis and MFM tags may be detected as misspellings, which can be annoying.

For text blocking, I don't understand what it means. Could you describe more about it?

@Linkachus17
Copy link
Author

What I mean with buggy Text blocking is: When I try to drag one of the caret (or whatever it is actually called) it’s just doesn’t want to drag. I have attached a screen recording in hoping to give you better understanding of the issue

ScreenRecording_10-29-2024.10-17-13.AM_1.mp4

@poppingmoon
Copy link
Owner

Thank you for reporting this.

I have implemented the spell check option in #458 and fixed the unwanted behavior of the text selection range in #459.

If you find the problem continues, please let me know.

@Linkachus17
Copy link
Author

Sorry, but I also forgot to mention about App Push Notification. Will that be added or still planned to have App Push Notification?

@poppingmoon
Copy link
Owner

The push notifications feature was added in #406. You can try it via TestFlight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants