panic in wgpu 0.18.0 when AMDVLK 2023.Q4.3 on Radeon RX 7900 XTX #30
Comments
|
Is there an open wgpu issue for this? |
|
Not yet, I'll raise one when I'm back at a computer |
|
Reported: gfx-rs/wgpu#5021 |
|
After being prompted over there, I tested in X11 and other compositors... I could not reproduce this panic in I'd previously encountered an earlier bug in AMDVLK that was breaking wgpu so I incorrectly assumed it was another similar occurrence |
|
So with AMDVLK, this wouldn't be using Mesa's EGL/Vulkan WSI code, and instead would use AMD's own implementation? Looking at https://github.com/GPUOpen-Drivers/pal/blob/dev/src/core/os/amdgpu/wayland/waylandWindowSystem.cpp, it seems to require So it may be a bug with cosmic-comp's Logs from running the client with |
|
Okay, I ran logs |
|
So the client is trying to use But |
|
Yeah, I think |
|
I can add more instrumentation somewhere and recompile to find out? |
|
I'd probably change https://github.com/pop-os/cosmic-comp/blob/f75d89b4240fb25f6e43443efd18f95c8484a620/src/wayland/protocols/drm.rs#L93-L98 to something like: for format in global_data.formats.iter() {
dbg!(format);
if let Ok(converted) = dbg!(wl_drm::Format::try_from(*format as u32)) {
drm_instance.format(converted as u32);
}
}I'm not really familiar with AMDVLK, but I should be able to test it, assuming it works with any modern integrated AMD GPU. |
|
Hmmm, I've tried compiling I even put a trivial Do I need to run |
|
Oh yeah. |
|
Okay, I instrumented the start of cosmic-comp::main() and cosmic-comp::wayland::protocols::drm::WlDrmState::bind() , as well as the body of the I can see that |
|
Seems AMDVLK recently dropped support for older graphics, including the Renoir APU I have handy, but https://github.com/GPUOpen-Drivers/AMDVLK/releases/tag/v-2023.Q3.3 works. I am able to reproduce the issue easily with that. |
|
Ah, so Removing that gives me I could make sense that Mesa is requiring explicit modifiers for import while AMDVLK needs |
|
Smithay/smithay#1274 seems to fix this. |
|
Also an issue to see if amdvlk will implement zwp-linux-dmabuf-v1: GPUOpen-Drivers/pal#96 |
|
Yeah, AMDVLK should move to the dmabuf protocol, and probably make use of explicit modifiers. RADV likely offers overall better Wayland support, though there is still more to improve in Mesa's Vulkan and EGL Wayland WSI support. |
|
This should be fixed now that the Smithay PR is merged, and cosmic-comp has updated Smithay. |
|
I can confirm that this is fixed for me: pop-os/cosmic-epoch#186 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
cosmic-termto be unable to be launched from anywhere where environment variables are unable to be customised (e.g.cosmic-launcher,cosmic-app-library, etc)launching
cosmic-termorAMD_VULKAN_ICD=AMDVLK cosmic-termresults in the following error:all of these do work, however:
AMD_VULKAN_ICD=RADV cosmic-termworks just finecosmic-launcher, etcI do not expect this to be addressed in wgpu nor
cosmic-term(but awareness may be handy later)The text was updated successfully, but these errors were encountered: