We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently origin whitelisting requires explicit string matching of the origin domain:
portal-api/src/services/pocket-relayer.ts
Line 584 in 7db2227
Being able to whitelist a collection of subdomains like *.domain.com is an intuitive process.
*.domain.com
The checkWhitelist enforcement function takes a type argument that could allow for a "wildcard" type which could check for a pattern match i.e.:
checkWhitelist
type
for (cost test of tests) { switch (type) { case 'wildcard': if (check.toLowerCase().match(test.toLowerCase()) != null ) { return true; } break; case 'explicit': if (test.toLowerCase() === check.toLowerCase()) { return true; } break; default: if (check.toLowerCase().includes(test.toLowerCase())) { return true; } } } return false;
The text was updated successfully, but these errors were encountered:
I don't have any objections against this. It is a low hanging fruit that can certainly be helpful for some. cc: @rem1niscence @nymd
Sorry, something went wrong.
No branches or pull requests
Currently origin whitelisting requires explicit string matching of the origin domain:
portal-api/src/services/pocket-relayer.ts
Line 584 in 7db2227
Being able to whitelist a collection of subdomains like
*.domain.com
is an intuitive process.The
checkWhitelist
enforcement function takes atype
argument that could allow for a "wildcard" type which could check for a pattern match i.e.:The text was updated successfully, but these errors were encountered: