Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factories Refactor: StorageReader: Router #910

Closed
kennylavender opened this issue Dec 13, 2018 · 1 comment · Fixed by #911
Closed

Factories Refactor: StorageReader: Router #910

kennylavender opened this issue Dec 13, 2018 · 1 comment · Fixed by #911
Assignees
@kennylavender
Labels
refactor released

Comments

@kennylavender
Copy link
Contributor

part of #903

Refactor the router to a factory with the least amount of changes possible.
@kennylavender kennylavender self-assigned this Dec 13, 2018
@kennylavender kennylavender added this to the PML1 milestone Dec 13, 2018
@kennylavender kennylavender mentioned this issue Dec 13, 2018
Merged
kennylavender added a commit that referenced this issue Dec 13, 2018
@kennylavender
Merge branch 'master' into kenny-#910
554d257
@kennylavender kennylavender changed the title Factories Refactor: StroageReader: Router Factories Refactor: StorageReader: Router Dec 13, 2018
@poet-ci
Copy link

poet-ci commented Dec 13, 2018

🎉 This issue has been resolved in version 2.18.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kennylavender kennylavender

Labels
refactor released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Factories Refactor: StorageReader: Router poetapp/node
3 participants
@lautarodragan @kennylavender @poet-ci