fix: bug where restoring value when leaving minimalist mode

[ilan-schemoul]

Problem

This fixes a bug where leaving minimalist mode crashes the plugin. If you have for example "set numberwidth=1" the current code will interpret 1 as a boolean value. So when we leave minimalist mode the plugin naively tries to do "set numberwidth=true" which leads to a crash. The reason the current code tries to intepret 1 as boolean is that sometimes it does represent a boolean. But always intepreting numbers as boolean is naive and leads to crashes.

Solution

We save numbers as numbers (instead of saving them as booleans if the number = 1).
Then let's say we try to restore the value "ruler" and the original value is "1" (as it is how vim represents a boolean) then we will try "set ruler=1". It will produce a bug which will be detected by pcall. So now we enter the if block and we try to do "set ruler" which works.

Observation 1

(type(opt) == "number" and (opt == 1 and true or false) or opt) nested ternary are hard to read and confusing. Also opt == 1 and true or false can be replaced by opt == 1
Instead of the ternary statement we can do:

if type(opt) == "number" then
  original_opts[user_opt] = opt == 1
else
 original_opts[user_opt] == op
end

is much much clearer. I have deleted this part of the code as I don't need it anyway but I would advise to prioritize clean, simple code (with a bit more comments) as opposed to unclear code with nested ternary statements.

[ilan-schemoul]

@pocco81 can you please take a look ?

[ilan-schemoul]

@pocco81 hey please I'd really love that you'd take a look