Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only check packageManager if it actually specifies pnpm #143

Closed
wants to merge 3 commits into from

Commits on Aug 23, 2024

  1. Only check packageManager if it actually specifies pnpm

    We upgrade to version 4 and started seeing the following weird error:
    
    ```
    Error: Multiple versions of pnpm specified:
      Error: Error: Multiple versions of pnpm specified:
        - version 9 in the GitHub Action config with the key "version"
        - version [email protected]+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e in the package.json with the key "packageManager"
      Remove one of these versions to avoid version mismatch errors like ERR_PNPM_BAD_PM_VERSION
        - version 9 in the GitHub Action config with the key "version"
        - version [email protected]+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e in the package.json with the key "packageManager"
    ```
    
    Even though we don't specify `packageManager` in `package.json` explicitly.
    
    Either way this change seems like an improvement to do `pnpm` version validation only if it's actually `pnpm`.
    fkorotkov authored Aug 23, 2024
    Configuration menu
    Copy the full SHA
    9ea357d View commit details
    Browse the repository at this point in the history
  2. Use includes

    fkorotkov authored Aug 23, 2024
    Configuration menu
    Copy the full SHA
    37c5a43 View commit details
    Browse the repository at this point in the history
  3. Use single quotes

    fkorotkov authored Aug 23, 2024
    Configuration menu
    Copy the full SHA
    80a65d4 View commit details
    Browse the repository at this point in the history