Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds command spo list defaultvalue clear #6534

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adds command spo list defaultvalue clear #6534

wants to merge 2 commits into from

Conversation

milanholemans
Copy link
Contributor

Closes #6505

@milanholemans milanholemans force-pushed the spo-listdefaultvalue-clear branch from eccaa2f to acb5190 Compare December 23, 2024 18:55
@milanholemans milanholemans force-pushed the spo-listdefaultvalue-clear branch 2 times, most recently from 4bc05d4 to 6215074 Compare January 11, 2025 15:08
@martinlingstuyl martinlingstuyl self-assigned this Jan 15, 2025
martinlingstuyl
martinlingstuyl requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and works fine Milan! The same comment as the other PR's, I'll merge it asap after you picked that up.

src/m365/spo/commands/list/list-defaultvalue-clear.ts Show resolved Hide resolved
@martinlingstuyl martinlingstuyl marked this pull request as draft January 15, 2025 12:51
@milanholemans milanholemans force-pushed the spo-listdefaultvalue-clear branch from 6215074 to 55d21fb Compare January 17, 2025 22:47
@milanholemans milanholemans marked this pull request as ready for review January 17, 2025 22:47
martinlingstuyl
martinlingstuyl approved these changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb! One comment again, but I can also do that while merging...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinlingstuyl martinlingstuyl martinlingstuyl approved these changes

Assignees

@martinlingstuyl martinlingstuyl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New command: spo list defaultvalue clear
2 participants
@milanholemans @martinlingstuyl