-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support node
module resolution
#151
Comments
shouldnt module resolution node16 or nodenext be enough. Node 16 isnt even supported anymore, so setting the module resolution to it should be a fine requirement for all your users, right? |
The tricky part is that downstream users may be using I know |
Since the work to support this is on yoga's side, I dont have a strong opinion here, but I honestly would rather tell people to change to recommended settings, then to keep investing time into supporting unsupported configurations while there's still a long roadmap for the library itself. Its not important here, but I wanted to clarify it anyways :D |
Fair enough! 😄 Makes sense to focus on the roadmap - just wanted to raise the compatibility point since I'm running into it. Let's see what the yoga folks say. Thanks for the quick response! |
ts4 support in yoga not planned - facebook/yoga#1764 (comment) |
Issue
Currently
@pmndrs/uikit
fails withnode
module resolution due toyoga-layout
's package exports configuration.Blocked by: facebook/yoga#1760
Once the
yoga-layout
maintainers implement a fix, it would be great to update@pmndrs/uikit
to incorporate their changes.Current Error
This is a tracking issue to implement the fix once available upstream.
The text was updated successfully, but these errors were encountered: