Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: Rename prop on Svg/Icon from color to fill #139

Open
Ledzz opened this issue Nov 4, 2024 · 0 comments
Open

Suggestion: Rename prop on Svg/Icon from color to fill #139

Ledzz opened this issue Nov 4, 2024 · 0 comments

Comments

@Ledzz
Copy link
Contributor

Ledzz commented Nov 4, 2024

I'm proposing to rename prop on Svg/Icon from color to fill. The reason is: if you use DefaultProperties with color on it (if you want to style text by default) all the icons become this color and loose their colors specified in svg sources. Also I feel like it closer to native css implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ledzz