-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement color grading effects #584
Comments
I might suggest going an additional step and include a CDLEffect, based on ASC CDL v1.2 color grading. It's a single effect with four parameters (vec3 slope, vec3 offset, vec3 power, float saturation) that should be able to accomplish everything supported by the other effects listed here. I'm making a similar proposal for three.js core fairly soon. |
That's even better 👍 I'll update the task. |
FYI: this ticket is not a blocker for v7 and since I'm not familiar with CDL, I'll leave you to it @donmccurdy. Meaning I won't be checking in here 😄 |
Thanks @vanruesc! Next on my list after a glTF Transform v4 release that has been taking me longer than planned. 😅 |
Description
Implement a
CDLEffect
.BrightnessContrastEffect
,HueSaturationEffect
andSepiaEffect
Reference:
Tasks
CDLEffect
.cdl
demo.Implementation Details
brightness-contrast
,hue-saturation
andsepia
manual demos from v6 as reference.The text was updated successfully, but these errors were encountered: