Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate revamped CallbackValidator #6343

Open
dktapps opened this issue May 6, 2024 · 0 comments
Open

Integrate revamped CallbackValidator #6343

dktapps opened this issue May 6, 2024 · 0 comments
Labels
Category: Core Related to internal functionality Type: Enhancement Contributes features or other improvements to PocketMine-MP

Comments

@dktapps
Copy link
Member

dktapps commented May 6, 2024

Description

A couple of months ago, I rewrote CallbackValidator, with an improved API and support for stuff like union and intersection types.
https://github.com/pmmp/CallbackValidator/tree/rewrite

However, these improvements required some BC breaks.
This is a problem, because we have no clear documentation of which dependency libraries are considered API and which aren't.
This means that plugins could have used the legacy CallbackValidator API directly instead of Utils::validateCallableSignature().

We have 2 choices:

  • Repackage CallbackValidator under a new name and namespace to allow it to coexist with the legacy CallbackValidator in 5.x
  • Wait until 6.0 to integrate it

Alternative methods

@dktapps dktapps added Category: Core Related to internal functionality Type: Enhancement Contributes features or other improvements to PocketMine-MP labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Core Related to internal functionality Type: Enhancement Contributes features or other improvements to PocketMine-MP
Projects
None yet
Development

No branches or pull requests

1 participant