Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate blockstate upgrader system into a library #6312

Open
dktapps opened this issue Mar 29, 2024 · 0 comments
Open

Separate blockstate upgrader system into a library #6312

dktapps opened this issue Mar 29, 2024 · 0 comments
Labels
Category: Core Related to internal functionality Type: Enhancement Contributes features or other improvements to PocketMine-MP

Comments

@dktapps
Copy link
Member

dktapps commented Mar 29, 2024

Description

pocketmine\data\bedrock\block\upgrade can be separated into a library by itself, if we remove its dependency on BlockStateData and have it operate on NBT directly.

Justification

Scope isolation, easier to test, easier for third party tools to use

Alternative methods
@dktapps dktapps added Category: Core Related to internal functionality Type: Enhancement Contributes features or other improvements to PocketMine-MP labels Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Core Related to internal functionality Type: Enhancement Contributes features or other improvements to PocketMine-MP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dktapps