Remove ThreadManager
#6205
Labels
Category: Core
Related to internal functionality
Type: Cleanup
Removes or deprecates API methods or behaviour
Description
The only remaining uses for ThreadManager are:
ext-pmmpthread
directly__destruct()
'd under normal circumstances, which ThreadManager actually interferes with by keeping strong referencesjoin()
which will be called directly byext-pmmpthread
during__destruct()
detach()
and/or leaking threads - not a particularly useful case, and can also be simulated more intentionally by implementingdetach()
inext-pmmpthread
directlyServerKiller
functionality to work - not sure how to replace or remove thisIn addition:
join()
'd before its children are alsojoin()
'd. At best we would want to stop them in reverse order, which it's never done.TL;DR: ThreadManager no longer serves a useful purpose, and is actually probably detrimental in some cases.
The text was updated successfully, but these errors were encountered: