import v4.2 changelog; populate v5.1 changelog with already voted-in items #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abouteiller
force-pushed
the
issue513/import42changelog
branch
from
dddbdd7 to
8512fb3
Compare
|
We have an unexpected difficulty: we deprecated some attributes and constants twice (in 5.0, and again in 4.2). This causes our automated checker to fail (because it verifies that we indeed deprecate and remove things only once, see We may have to special-case the checker to not complain about these instances :( |
|
Solution preferred during discussion at ASC 24M06 is to special case these in the python. |
|
Errata PR 514 vote passed from the ASC 2024-Q3 voting |
abouteiller
force-pushed
the
issue513/import42changelog
branch
from
8512fb3 to
36f6770
Compare
|
Should be ready to go please double check my python |
abouteiller
commented
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update master revision history
closes: Import v4.2 changelog to v5.1 (master) #513