Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selection of Pairs #28

Closed
2 of 4 tasks
theimo1221 opened this issue Feb 17, 2018 · 3 comments
Closed
2 of 4 tasks

Add selection of Pairs #28

theimo1221 opened this issue Feb 17, 2018 · 3 comments

Comments

@theimo1221
Copy link
Contributor

theimo1221 commented Feb 17, 2018

Hello team,

needed Tasks:

Thanks and Greets

Theimo

@pmaji
Copy link
Owner

pmaji commented Feb 18, 2018

Love the idea of letting the user pick pairs.
I'm not familiar enough with what would be easiest for JS, but I think maybe a Checkbox would be best, that way users could the choice to still show more than one pairing per page (something that JDAX doesn't do). We could set it so that default is to show just ETH/USD first to save on load time.

Let me know what you think and what might be easiest via JS?

@theimo1221
Copy link
Contributor Author

Okay if we do so. We should consider to just use one update for all data as written in #29

theimo1221 added a commit to theimo1221/eth_python_tracker that referenced this issue Feb 18, 2018
Needed for pmaji#28.
Compatible with modular increase of pairs pmaji#36
@theimo1221
Copy link
Contributor Author

theimo1221 commented Feb 18, 2018

One update for all data achieved in #40
Button to show/ Hide Graph works aswell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants