Skip to content

Commit 3079872

Browse files
stonebuzzRom1-B
andauthored
Fix(Tab): Fix form path for tab container (#1100)
* Fix(Tab): fix form for * Apply suggestion from @Rom1-B * fix tests * fix tu --------- Co-authored-by: Romain B. <[email protected]> Co-authored-by: Rom1-B <[email protected]>
1 parent 21c0dd1 commit 3079872

File tree

4 files changed

+5
-3
lines changed

4 files changed

+5
-3
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
77

88
## [Unreleased]
99

10+
- Fix form `path` for `tab` `container`
11+
1012
## [1.23.1] - 2025-11-20
1113

1214
- Fix `add` operations when a linked object already exists before the plugin container fields are created.

templates/forms/tab_container.html.twig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
<div class="row flex-row">
3434

3535
{% if canedit %}
36-
<form method='POST' class='mt-5' action='/plugins/fields/front/container.form.php'>
36+
<form method='POST' class='mt-5' action='{{ path("/plugins/fields/front/container.form.php") }} '>
3737
<input type="hidden" name="plugin_fields_containers_id" value="{{ c_id }}">
3838
<input type="hidden" name="items_id" value="{{ item.getID() }}">
3939
<input type="hidden" name="itemtype" value="{{ item.getType() }}">

tests/QuestionTypeTestCase.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@
3030

3131
namespace GlpiPlugin\Field\Tests;
3232

33-
use DbTestCase;
3433
use Glpi\Controller\Form\RendererController;
3534
use Glpi\Form\Form;
35+
use Glpi\Tests\DbTestCase;
3636
use Glpi\Tests\FormTesterTrait;
3737
use PluginFieldsContainer;
3838
use PluginFieldsField;

tests/Units/FieldDestinationFieldTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
use Glpi\Form\Destination\FormDestinationProblem;
3737
use Glpi\Form\Form;
3838
use Glpi\Form\QuestionType\QuestionTypeShortText;
39+
use Glpi\Tests\AbstractDestinationFieldTest;
3940
use Glpi\Tests\FormBuilder;
4041
use Glpi\Tests\FormTesterTrait;
4142
use GlpiPlugin\Field\Tests\FieldTestTrait;
@@ -46,7 +47,6 @@
4647
use PluginFieldsDestinationField;
4748
use PluginFieldsQuestionType;
4849
use Problem;
49-
use tests\units\Glpi\Form\Destination\CommonITILField\AbstractDestinationFieldTest;
5050
use Ticket;
5151
use User;
5252

0 commit comments

Comments
 (0)