Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Update to React 18? #121

Open
fergy-os opened this issue Jun 15, 2023 · 2 comments
Open

Question: Update to React 18? #121

fergy-os opened this issue Jun 15, 2023 · 2 comments

Comments

@fergy-os
Copy link

Are there any plans to update this library to React 18?

@alexcjohnson
Copy link
Collaborator

We created this package primarily to feed into Dash-cytoscape, and React 18 currently has experimental support in Dash. Which means that in the Dash context (where separate components are loaded independently in the browser so constraints like peerDependencies are ignored) this has been used with React 18 and AFAIK it has had no problems.

So I think we'd be fine to update the deps to allow React 18, as long as it didn't break 16, which is still going to be the default in Dash for a little while longer. Are you aware of anything else we would want to change here?

@akx
Copy link
Contributor

akx commented Jul 3, 2023

The peer dependency here is

"react": ">=15.0.0"

– is there something that's not working for you with React 18, @fergy-os?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants