Skip to content

Commit 880f838

Browse files
committed
adjust conditional Chrome flags
1 parent 6b00e45 commit 880f838

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

test/jasmine/karma.conf.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -261,11 +261,14 @@ func.defaultConfig = {
261261
'--touch-events',
262262
'--window-size=' + argv.width + ',' + argv.height,
263263
isCI ? '--ignore-gpu-blocklist' : '',
264-
// The following two flags are needed only for the "NoCI" tests which run in GitHub Actions,
265-
// since the GPU is not available to those runners and therefore we need to use SwiftShader instead.
264+
// The following three flags are needed only for the "NoCI" tests which run in GitHub Actions.
265+
// The first two are needed because the GPU is not available to those runners,
266+
// and therefore we need to use SwiftShader instead.
267+
// The third flag is needed because the Chrome browser installed by the CI job runner
268+
// fails without it.
266269
isCI && process.env.GITHUB_ACTIONS ? '--use-gl=angle' : '',
267270
isCI && process.env.GITHUB_ACTIONS ? '--use-angle=swiftshader' : '',
268-
isCI ? '--no-sandbox' : '',
271+
isCI && process.env.GITHUB_ACTIONS ? '--no-sandbox' : '',
269272
isBundleTest && basename(testFileGlob) === 'no_webgl' ? '--disable-webgl' : ''
270273
]
271274
},

0 commit comments

Comments
 (0)