-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove _timestamp
properties
#3055
Comments
I agree - but do you think it's still important for other languages? Not sure if that's important if they are no longer being supported. Here is an R example Also is it necessary in the DataTable? |
IMO since this is a major version bump of Dash, if other languages want to upgrade their dependencies on the main components it’s reasonable to ask them to support the |
Yes, I think we can remove this from
I have a vague recollection of there being a reason to keep it for
|
Thanks @alexcjohnson and @AnnMarieW - @T4rk1n, please pull it out. (I love deleting code in the morning...) |
I think that is what we have that can trigger a callback without an input on the data itself. Like you may want to update some last saved element but don't need the data to be transfered. |
@T4rk1n @alexcjohnson @AnnMarieW please thumbs-up if you believe we can remove |
Yes - all except |
Does that same argument apply to DataTable data_timestamp? Otherwise the props are all small so no reason not to fully transfer them, seems like this is just a performance hack for very large props |
TBH though I’m not sure that’s a good enough reason to keep these props around. It’s a very niche case (how often do you really care that something changed but not care what the new value is?), and the same could be accomplished with a small clientside callback bound to the full prop outputting to another prop (an extra store just for this purpose, for example) then you use that as the input to your serverside callback that doesn’t need the full data transferred. |
The
_timestamp
properties have been essentially useless sincecallback_context
was introduced - they should be removed. cc @alexcjohnson @AnnMarieWThe text was updated successfully, but these errors were encountered: