Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor list] Notes on possible refactor tasks #131

Open
salamca opened this issue Aug 10, 2022 · 0 comments
Open

[Refactor list] Notes on possible refactor tasks #131

salamca opened this issue Aug 10, 2022 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@salamca
Copy link
Contributor

salamca commented Aug 10, 2022

BE


Route entity has a field named routeType whereas crag entity has a field named type


Rename current Admin role to Editor


snake_case db collumn names.
(If we decide to do it. needs some more discussion)


activity <--> activity_route
there is a slight confusion in naming this relation: in many places it activity_routes are called just routes, which might lead to thinking that these are actual routes when in fact they are entries in a pivot table...
should think about renaming it to activity_route in all occurrences.


remove column status from crag table
column status is deprecated
instead of it, we have 2 other columns now> publishStatus and isHidden

also sector table has a status column, which it seems was reduced to publishStatus, but there is no isHidden column


remove db triggers and implement same logic in api


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
Status: To do
Development

No branches or pull requests

1 participant