Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Regarding removal of incomming webhooks comming this 1st october #17

Open
Az8th opened this issue Sep 29, 2024 · 1 comment

Comments

@Az8th
Copy link
Contributor

Az8th commented Sep 29, 2024

Hello @estruyf,

It is stated in the readme that

Microsoft Teams incoming webhook (retiring October 1, 2024)

As this will be due in 2 days, I propose to address this rapidly to encourage people still using it to switch to the Power Automate ones.

Should we then...

  1. remove both the webhookType parameter and the logic behind using the msteams option completely ? (Users that will update the package would face an error as this parameter would not be recognized)
  2. deprecate it and replace all the code used when it is set to msteams with a warning indicating this method no longer works ? (Less brutal and dedicated message, while no impact on powerautomate users, as it is set by default and therefore not mandatory to mention it in the config file)
  3. same as option 2, minus deprecation, in case new methods may emerge later ?

Or chose another way ?

If needed, I can provide a PR that would respect your choice
Thanks again for the awesome work !

@estruyf
Copy link
Collaborator

estruyf commented Sep 29, 2024

Hi @Az8th, deprecation has been extended to December 2025, so we can leave it as is. Although I like the deprecation notice on the msteams webhook type property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants