Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Error handling middleware expansion opportunity? #86

Open
yuvalherziger opened this issue Apr 28, 2022 · 1 comment
Open
Labels
feat A new feature

Comments

@yuvalherziger
Copy link

Hey @playpauseandstop, first off, I dig this project very much just by browsing the code and the docs - great work.

While I never tried using your library, I've stumbled upon it on aiohttp's third-party libraries list and it caught my attention. A few months ago, I started putting together a library I titled aiohttp-catcher, which fulfills a very similar purpose aiohttp-middlewares's error_middleware does. aiohttp-catcher does it a bit differently, but the general idea is similar and I trust its repo's README file is useful in understanding how it works. Alas, the library never took off as I haven't really advertised it too ambitiously and I've only been using it in a few apps I run for non-commercial purposes.

My question is this: would you be interested in joining forces and work together on porting some of the logic of aiohttp-catcher into aiohttp-middlewares's error_middleware? I'm more than willing to do the heavy lifting myself. That is, if the architecture of aiohttp-catcher makes sense to you. Happy to start a discussion one way or another.

P.S.,
I couldn't help but notice your location - I hope that you and your close ones are safe 🇺🇦 ❤️

@playpauseandstop
Copy link
Owner

Hi @yuvalherziger,

First of all thank for your warm words, I and all my close ones are safe now!

As of joining forces, I am intriguing for sure, as I know how hard is to promote own solutions, so let me briefly go through aiohttp-catcher and let you know if this join will be possible from my perspective.

I am not setting the exact ETA for my review, but expecting to complete it by EOW.

Thanks and talk to you soon!

@playpauseandstop playpauseandstop added the feat A new feature label Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat A new feature
Projects
None yet
Development

No branches or pull requests

2 participants