-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Java 21 #1458
Comments
I forked a Java 21 branch for my own local testing: I had to use Eclipse JDT Core Batch compiler Stable release 4.30M1, as 4.29 release doesn't have the VERSION_21 compiler option. |
I am already able to do a basic debug run adding "21" as a String through a non-suspending breakpoint in my IDE, over an 1.7.1. But better do proper updates and checks for the sources and dependencies for sure. |
I had the experience with RePlay that all worked well until I upgraded beyond JDK 18. Hibernate 5.6 does not support it. |
I updated the libraries ecj and jdt core to support JDK 21 compilation target. The number 21 was added to the list of compatible java versions. See this pull request. I was able to compile a switch expression with pattern matching. |
As long as Play1 prescribes Hibernate 5.6 it is technically not able to support beyond JDK18 (the upper limit of Hibernate 5.6). Not sure what will break, maybe the Hibernate devs/ issues tracker can elaborate on this. |
Play Version
1.7.1
Operating System
All
JDK
21
Library Dependencies
.
Expected Behavior
Start and run fine with JDK 21.
And possibly update Java source doc to add Java 16, as it seems to be missing in the list while correct in the source code.
Actual Behavior
The text was updated successfully, but these errors were encountered: