-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade com.ning:async-http-client to org.asynchttpclient:async-http-client #1426
Comments
@sp00m Yes, sure, it would be great to upgrade Play accordingly. |
@sp00m Wait, no, we cannot upgrade. This library requires Netty 4.1.60.Final, but Play1 still uses Netty 3.x |
Ouch, good catch! Looks like migrating to Netty 4 is WIP: #1284. That doesn't seem easy though, according to the discussions on that issue :/ |
An attempt was also made to upgrade this on RePlay (a Play1 fork): replay-framework/replay#25 It's quite close, but serving static assets is still a pain point iirc. |
Would it be an alternative to use Java's "new" built in HttpClient? Support both send() and sendAsync(). |
Play v1.7.1 still relies on an old version of AsyncHttpClient: https://github.com/playframework/play1/blob/1.7.1/framework/dependencies.yml#L21.
This library has moved from https://github.com/ning/async-http-client (last commit in 2016) to https://github.com/AsyncHttpClient/async-http-client.
Should we upgrade Play accordingly?
The text was updated successfully, but these errors were encountered: