Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation mismatch on sample code #398

Open
kmcheung12 opened this issue May 4, 2017 · 1 comment
Open

Documentation mismatch on sample code #398

kmcheung12 opened this issue May 4, 2017 · 1 comment

Comments

@kmcheung12
Copy link

In the documentation, it states Play Slick currently supports Slick 3.1 with Play 2.5, for Scala 2.11..

However, in sample code, the slick version used is 3.2.0

slick.driver.JdbcProfile is moved to slick.jdbc.JdbcProfile in slick 3.2.0. It can be confusing when there is no mention which package to be imported in the documentation and the reference implementation is not using the slick version specified in the doc

@marcospereira
Copy link
Member

Thanks @kmcheung12.

The documentation page is here: https://github.com/playframework/play-slick/blob/2.1.x/docs/manual/working/scalaGuide/main/sql/slick/PlaySlick.md

Do you want to submit a PR to update it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants