Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade preflight check should fail if machines in cctl state file is different from Kubernetes nodes #112

Open
puneetguptanitj opened this issue Sep 7, 2018 · 1 comment

Comments

@puneetguptanitj
Copy link
Contributor

Let us define the following two sets

S = machines in state file with master role
C = node objects with label master as reported by kubectl get nodes

Currently preflight check checks if the nodes in set C are ready

  • In most cases S == C, and preflight check does the right thing
  • However if there are out of band operations like node being deleted by kubectl delete node or state file being edited then S-C or C-S can be non empty sets. In that case
    • The upgrade is bound to fail (S-C not empty)
    • or Succeed only partially (C-S not empty)
    • Both can be avoided by adding this to the preflight check.

Update preflight check to do this set difference and fail fast if S != C

@puneetguptanitj puneetguptanitj changed the title Preflight upgrade preflight check should fail if machines in cctl state file are different nodes reported by kubernetes Upgrade preflight check should fail if machines in cctl state file is different from Kubernetes nodes Sep 7, 2018
@sarun87 sarun87 closed this as completed Sep 11, 2018
@puneetguptanitj
Copy link
Contributor Author

Discussed with Arun this is needs to be fixed reopening the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants