You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
S = machines in state file with master role
C = node objects with label master as reported by kubectl get nodes
Currently preflight check checks if the nodes in set C are ready
In most cases S == C, and preflight check does the right thing
However if there are out of band operations like node being deleted by kubectl delete node or state file being edited then S-C or C-S can be non empty sets. In that case
The upgrade is bound to fail (S-C not empty)
or Succeed only partially (C-S not empty)
Both can be avoided by adding this to the preflight check.
Update preflight check to do this set difference and fail fast if S != C
The text was updated successfully, but these errors were encountered:
puneetguptanitj
changed the title
Preflight upgrade preflight check should fail if machines in cctl state file are different nodes reported by kubernetes
Upgrade preflight check should fail if machines in cctl state file is different from Kubernetes nodes
Sep 7, 2018
Let us define the following two sets
S = machines in state file with master role
C = node objects with label master as reported by
kubectl get nodes
Currently preflight check checks if the nodes in set C are
ready
kubectl delete node
or state file being edited then S-C or C-S can be non empty sets. In that caseUpdate preflight check to do this set difference and fail fast if S != C
The text was updated successfully, but these errors were encountered: