Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add germplasm Photos #593

Open
cpommier opened this issue Apr 15, 2024 · 5 comments
Open

Add germplasm Photos #593

cpommier opened this issue Apr 15, 2024 · 5 comments
Labels
BrAPI-Germplasm Related to BrAPI-Germplasm Modify Data Model Change an existing data model

Comments

@cpommier
Copy link
Member

each germplasm can have several descriptive pictures (grain, leaf, flower, ...)
we could add the following structure to germplasm:


 "medias": [
{
      "mime-type":"",
      "file": "https://urgi.versailles.inrae.fr/files/siregal/images/accession/CEREALS/6027_Mult13_Epi.jpg",
      "copyright": "INRA,  2013",
      "name": "RECITAL spike",
      "description": "Spike ; field multiplication 2013",
      "thumbnailFile": "https://urgi.versailles.inrae.fr/files/siregal/images/accession/CEREALS/thumbnails/thumb_6027_Mult13_Epi.jpg"
    },

]
@cpommier
Copy link
Member Author

What do you think @Nicolas971 @cmichotey

@Nicolas971
Copy link

Dans le cas où la base local a beaucoup de photo associé à une accession, y-a-t-il une façon de faire remonter la ou les photos principales ou prioritaires ? On affichera sans doute pas l'ensemble des photos dispos dans les bases locales ? Une propriété d'ordre ?

@cpommier
Copy link
Member Author

We could add an order field indeed. Not sure it will be filled though

@BrapiCoordinatorSelby BrapiCoordinatorSelby added Modify Data Model Change an existing data model BrAPI-Germplasm Related to BrAPI-Germplasm labels Apr 15, 2024
@BrapiCoordinatorSelby
Copy link
Member

The proposed structure above has almost a full overlap with the existing BrAPI Image entity. I would propose something like this:

"media": [
    {
        "imageDbId": "xyz",
        "imageName": "XYZ"
    }
]

You could add an order field, or you could rely on the natural order of the array, or you could look at Image.descriptiveOntologyTerms a list of descriptive tags for each image. Tag one of the images as "Primary Display" or something like that. I'm not sure if there is an official ontology or controlled vocabulary for something like that, but BrAPI won't care.

@cpommier
Copy link
Member Author

After discussion with Alice, Nicolas, Célia, Francianne, we propose:

       "germplasm":{
            "accessionNumber": "A0000003",
             [...],
          "media": [
           {
                "imageDbId": "xyz",
               "imageName": "XYZ",
               "imageURL": "http://foo.bar/baz"
           },
           {
                "imageDbId": "xyz2",
               "imageName": "XYZ2",
               "imageURL": "http://foo.bar/baz2"
           }
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BrAPI-Germplasm Related to BrAPI-Germplasm Modify Data Model Change an existing data model
Projects
None yet
Development

No branches or pull requests

3 participants