Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for advanced pedigree notation #589

Open
trife opened this issue Mar 13, 2024 · 2 comments
Open

Add support for advanced pedigree notation #589

trife opened this issue Mar 13, 2024 · 2 comments
Labels
BrAPI-Germplasm Related to BrAPI-Germplasm Existing Standard Modify t accomidate an existing data standard Modify Data Model Change an existing data model

Comments

@trife
Copy link

trife commented Mar 13, 2024

Current pedigree only includes the simple pedigree string - "pedigreeString": "Jamestown/AGS 2060"

Advanced pedigree notation (standardized around the Purdy format) allows more complex pedigree structure - "Jamestown/3/FR-81-19/FL-302//FL-302/IN-71761-A-3-31-5-48"

A more comprehensive implementation could allow for more formats - "pedigreeString": [ { "string": "Jamestown/AGS 2060", "type": "simple" }, { "string": "Jamestown/3/FR-81-19/FL-302//FL-302/IN-71761-A-3-31-5-48", "type": "purdy" }]

@BrapiCoordinatorSelby BrapiCoordinatorSelby added Question Outstanding question Existing Standard Modify t accomidate an existing data standard Modify Data Model Change an existing data model BrAPI-Germplasm Related to BrAPI-Germplasm and removed Question Outstanding question labels Mar 13, 2024
@BrapiCoordinatorSelby
Copy link
Member

All the examples have a simple pedigree string because it is shorter, but there is no reason why the "pedigreeString" field couldn't be used for Purdy notation right now. Are there use cases where you would want both/multiple versions? Is this truly an issue with the BrAPI spec or an issue with a data provider who is not sending Purdy notation? Could this be achieved with a request parameter? /pedigree?pedigreeStringNotation=purdy

@trife
Copy link
Author

trife commented Mar 16, 2024

pedigreeString could be used for Purdy notation right now, but having it specifically marked as Purdy format would act as a catch for downstream tools that want to parse it using Purdy notation rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BrAPI-Germplasm Related to BrAPI-Germplasm Existing Standard Modify t accomidate an existing data standard Modify Data Model Change an existing data model
Projects
None yet
Development

No branches or pull requests

2 participants