-
Notifications
You must be signed in to change notification settings - Fork 470
Description
Describe the bug
-
After setting the fallback version at a given point, the downgrade for previous and successfully migrations are being executed, but they shouldn't, see: https://github.com/pkp/ojs/pull/3895/files#r1207504069.
-
As an improvement to the upgrade process, the "save point" should probably be set automatically after every successfully migration (e.g. Status: pre-3.4.0 failed at migration XYZ), it should make the life of technically skilled users easier.
-
Re-think our downgrade strategy: Downgrades are mostly useful to allow users to revert to a previous version without losing newer data and to speed up things (e.g. run a couple of updates instead of restoring a huge dataset from a backup).
Given that we have a win/lose condition (e.g. reverting a single database migration is pointless/wrong, unless we can do it on the code as well), we've got to either implement thedown()method properly (store deleted data + ensure newer data will be handled properly) in all migrations or ignore it altogether (for now I personally support the latter).
Perhaps this should be a discussion 🤔